refactor(governance-sdk): DRYer Borsh classes, remove repeated properties & constructors #496
+115
−431
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a proposal to refactor serializable Borsh classes so that there is no repetition of their arguments, as this can create a lot of extra lines of code that devs might potentially forget to update when adding/removing/updating struct properties.
Example 1. Class with no custom properties and/or instance methods
before
after
Example 2. Class with custom properties and/or instance methods
before
after
TODO
this.isWritable = !!args.isWritable;